Skip to content

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Jan 17, 2025

PR Summary

This PR adds ContainerRegistry as valid value to -ApiVersion for cmdlet Registery-PSResourceRepository.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 84272f4:

💡 Validation status: suggestions

File Status Preview URL Details
powershell-gallery/powershellget-3.x/Microsoft.PowerShell.PSResourceGet/Register-PSResourceRepository.md 💡Suggestion View (powershellget-3.x) Details

powershell-gallery/powershellget-3.x/Microsoft.PowerShell.PSResourceGet/Register-PSResourceRepository.md

  • Line 0, Column 0: [Suggestion: learn-site-link-broken - See documentation] Link '/powershell-gallery/docs-conceptual/powershellget/supported-repositories.md#azure-container-registry' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Jan 17, 2025

I tried to do relative linking from root with /powershell-gallery/docs-conceptual/powershellget/supported-repositories.md#azure-container-registry, instead of "climbing up" the path with ../... But that does not work?

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 1e9a6b9:

✅ Validation status: passed

File Status Preview URL Details
powershell-gallery/powershellget-3.x/Microsoft.PowerShell.PSResourceGet/Register-PSResourceRepository.md ✅Succeeded View (powershellget-3.x)

For more details, please refer to the build report.

For any questions, please:

@github-actions
Copy link

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b2f1710:

✅ Validation status: passed

File Status Preview URL Details
powershell-gallery/powershellget-3.x/Microsoft.PowerShell.PSResourceGet/Register-PSResourceRepository.md ✅Succeeded View (powershellget-3.x)
powershell-gallery/powershellget-3.x/Microsoft.PowerShell.PSResourceGet/Set-PSResourceRepository.md ✅Succeeded View (powershellget-3.x)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler merged commit 7d8c420 into MicrosoftDocs:main Jan 17, 2025
3 checks passed
@o-l-a-v o-l-a-v deleted the feature/psresourceget-register-repository-fix branch January 17, 2025 15:12
@Taojunshen Taojunshen mentioned this pull request Jan 17, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants